Fixes after feedback
This commit is contained in:
@@ -18,7 +18,7 @@ use crate::error::ErrorKind;
|
||||
use crate::unit::Unit;
|
||||
|
||||
/// Trait for things implementing [std::io::Read] + [std::io::Write]. Used in [TlsConnector].
|
||||
pub trait ReadWrite: Read + Write + Send + 'static {
|
||||
pub trait ReadWrite: Read + Write + Send + fmt::Debug + 'static {
|
||||
fn socket(&self) -> Option<&TcpStream>;
|
||||
fn is_poolable(&self) -> bool;
|
||||
|
||||
@@ -42,7 +42,7 @@ pub trait TlsConnector: Send + Sync {
|
||||
fn connect(
|
||||
&self,
|
||||
dns_name: &str,
|
||||
io: Box<dyn ReadWrite>,
|
||||
io: Box<dyn ReadWrite + Sync>,
|
||||
) -> Result<Box<dyn ReadWrite>, crate::error::Error>;
|
||||
}
|
||||
|
||||
@@ -95,6 +95,12 @@ impl Write for TestStream {
|
||||
}
|
||||
}
|
||||
|
||||
impl fmt::Debug for TestStream {
|
||||
fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result {
|
||||
f.debug_tuple("TestStream").finish()
|
||||
}
|
||||
}
|
||||
|
||||
// DeadlineStream wraps a stream such that read() will return an error
|
||||
// after the provided deadline, and sets timeouts on the underlying
|
||||
// TcpStream to ensure read() doesn't block beyond the deadline.
|
||||
@@ -175,7 +181,7 @@ pub(crate) fn io_err_timeout(error: String) -> io::Error {
|
||||
impl fmt::Debug for Stream {
|
||||
fn fmt(&self, f: &mut fmt::Formatter) -> fmt::Result {
|
||||
match self.inner.get_ref().socket() {
|
||||
Some(s) => write!(f, "{:?}", s),
|
||||
Some(_) => write!(f, "Stream({:?})", self.inner.get_ref()),
|
||||
None => write!(f, "Stream(Test)"),
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user