avoid parsing when setting headers

This commit is contained in:
Martin Algesten
2018-07-01 18:33:50 +02:00
parent 1812b7f6b8
commit 51744804da
4 changed files with 23 additions and 20 deletions

View File

@@ -117,9 +117,10 @@ impl Agent {
K: Into<String>,
V: Into<String>,
{
let s = format!("{}: {}", header.into(), value.into());
let header = s.parse::<Header>().expect("Failed to parse header");
add_header(&mut self.headers, header);
add_header(
&mut self.headers,
Header::new(&header.into(), &value.into()).expect("Failed to parse header"),
);
self
}
@@ -153,9 +154,7 @@ impl Agent {
I: IntoIterator<Item = (K, V)>,
{
for (k, v) in headers.into_iter() {
let s = format!("{}: {}", k.into(), v.into());
let header = s.parse::<Header>().expect("Failed to parse header");
add_header(&mut self.headers, header);
self.set(k, v);
}
self
}
@@ -187,6 +186,7 @@ impl Agent {
/// in all requests using the agent.
///
/// ```
/// // sets a header "Authorization: token secret"
/// let agent = ureq::agent()
/// .auth_kind("token", "secret")
/// .build();
@@ -200,9 +200,8 @@ impl Agent {
S: Into<String>,
T: Into<String>,
{
let s = format!("Authorization: {} {}", kind.into(), pass.into());
let header = s.parse::<Header>().expect("Failed to parse header");
add_header(&mut self.headers, header);
let value = format!("{} {}", kind.into(), pass.into());
self.set("Authorization", value);
self
}