From acaf449a4c008685981f57e20a05386ed875338c Mon Sep 17 00:00:00 2001
From: Joshua Nelson <joshua@yottadb.com>
Date: Sun, 8 Nov 2020 14:13:03 -0500
Subject: [PATCH] Allow getting the error from a response (#214)

This is an alternative to https://github.com/algesten/ureq/pull/132
which does not require breaking changes.

Closes https://github.com/algesten/ureq/issues/126.
---
 src/response.rs | 26 +++++++++++++++++++++++---
 src/unit.rs     |  2 +-
 2 files changed, 24 insertions(+), 4 deletions(-)

diff --git a/src/response.rs b/src/response.rs
index 75ba391..ae2aedf 100644
--- a/src/response.rs
+++ b/src/response.rs
@@ -213,14 +213,34 @@ impl Response {
         self.error.is_some()
     }
 
-    /// Get the actual underlying error when the response is
+    /// Get a reference to the actual underlying error when the response is
     /// ["synthetic"](struct.Response.html#method.synthetic).
     pub fn synthetic_error(&self) -> &Option<Error> {
         &self.error
     }
 
-    // Internal-only API, to allow unit::connect to return early on errors.
-    pub(crate) fn into_error(self) -> Option<Error> {
+    /// Get the actual underlying error when the response is
+    /// ["synthetic"](struct.Response.html#method.synthetic).
+    ///
+    /// This consumes the Response and it cannot be used again.
+    ///
+    /// # Example
+    ///
+    /// ```
+    /// // hold onto the error even after dropping the response
+    /// let err = {
+    ///     // scheme that this library doesn't understand
+    ///     let resp = ureq::get("borkedscheme://www.example.com").call();
+    ///
+    ///     // it's a synthetic error
+    ///     assert!(resp.error() && resp.synthetic());
+    ///
+    ///     // resp is dropped here, but the error lives on
+    ///     resp.into_synthetic_error()
+    /// };
+    /// println!("{}", err.unwrap());
+    /// ```
+    pub fn into_synthetic_error(self) -> Option<Error> {
         self.error
     }
 
diff --git a/src/unit.rs b/src/unit.rs
index 2957af1..1f0c43c 100644
--- a/src/unit.rs
+++ b/src/unit.rs
@@ -199,7 +199,7 @@ pub(crate) fn connect(
             return connect(req, unit, false, redirect_count, empty, redir);
         }
         // Non-retryable errors return early.
-        return Err(resp.into_error().unwrap());
+        return Err(resp.into_synthetic_error().unwrap());
     }
 
     // squirrel away cookies