lib/ureq
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove unnecessary cloning in Request::do_call()

Browse Source
This commit is contained in:
Martin Algesten
2021-01-26 20:08:55 +01:00
parent 566295bebb
commit c4c1618042
1 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/request.rs
View File

@@ -111,19 +111,19 @@ impl Request {
self.do_call(Payload::Empty) self.do_call(Payload::Empty)
} }
fn do_call(&self, payload: Payload) -> Result<Response> { fn do_call(self, payload: Payload) -> Result<Response> {
for h in &self.headers { for h in &self.headers {
h.validate()?; h.validate()?;
} }
let mut url: Url = match self.url.clone() { let mut url: Url = match self.url {
Urlish::Url(u) => u, Urlish::Url(u) => u,
Urlish::Str(s) => s.parse().map_err(|e: url::ParseError| { Urlish::Str(s) => s.parse().map_err(|e| {
ErrorKind::InvalidUrl ErrorKind::InvalidUrl
.msg(&format!("failed to parse URL '{}'", self.url)) .msg(&format!("failed to parse URL: {:?}", e))
.src(e) .src(e)
})?, })?,
}; };
for (name, value) in self.query_params.clone() { for (name, value) in self.query_params {
url.query_pairs_mut().append_pair(&name, &value); url.query_pairs_mut().append_pair(&name, &value);
} }
let deadline = match self.timeout.or(self.agent.config.timeout) { let deadline = match self.timeout.or(self.agent.config.timeout) {