lib/ureq
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove AgentBuilder::set headers

Browse Source 
The headers are not scoped by host, which means using them for
something like `Authorization` would effectively "leak" to all
requests using the agent.

Context:
https://github.com/algesten/ureq/issues/203#issuecomment-716385310
This commit is contained in:
Martin Algesten
2020-10-30 06:16:07 +01:00
parent d83de53bcd
commit e37acc85b2
3 changed files with 1 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/test/agent_test.rs
View File

@@ -1,6 +1,5 @@
#![allow(dead_code)]
use crate::test;
use crate::test::testserver::{read_headers, TestServer};
use std::io::{self, Read, Write};
use std::net::TcpStream;
@@ -8,29 +7,6 @@ use std::time::Duration;
use super::super::*;
#[test]
fn agent_reuse_headers() {
let agent = builder().set("Authorization", "Foo 12345").build();
test::set_handler("/agent_reuse_headers", |unit| {
assert!(unit.has("Authorization"));
assert_eq!(unit.header("Authorization").unwrap(), "Foo 12345");
test::make_response(200, "OK", vec!["X-Call: 1"], vec![])
});
let resp = agent.get("test://host/agent_reuse_headers").call().unwrap();
assert_eq!(resp.header("X-Call").unwrap(), "1");
test::set_handler("/agent_reuse_headers", |unit| {
assert!(unit.has("Authorization"));
assert_eq!(unit.header("Authorization").unwrap(), "Foo 12345");
test::make_response(200, "OK", vec!["X-Call: 2"], vec![])
});
let resp = agent.get("test://host/agent_reuse_headers").call().unwrap();
assert_eq!(resp.header("X-Call").unwrap(), "2");
}
// Handler that answers with a simple HTTP response, and times
// out idle connections after 2 seconds.
fn idle_timeout_handler(mut stream: TcpStream) -> io::Result<()> {