lib/ureq
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix cookies_on_redirect unittest.

Browse Source 
Previously this test relied on a specific ordering of cookies, which was
not guaranteed. This makes the test robust to random ordering.

Also, fix the check for the `second` cookie to actually check the right
cookie.
This commit is contained in:
Jacob Hoffman-Andrews
2020-09-13 11:55:31 -07:00
committed by Martin Algesten
parent 5cb212f7b7
commit f38c203215
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/agent_test.rs
View File

@@ -111,7 +111,7 @@ fn cookie_and_redirect(mut stream: TcpStream) -> io::Result<()> {
stream.write_all(b"Content-Length: 0\r\n\r\n")?; stream.write_all(b"Content-Length: 0\r\n\r\n")?;
}, },
"/second" => { "/second" => {
if headers.headers().iter().find(|&x| x.contains("Cookie: first")).is_none() { if headers.headers().iter().find(|&x| x.contains("first=true")).is_none() {
panic!("request did not contain cookie 'first'"); panic!("request did not contain cookie 'first'");
} }
stream.write_all(b"HTTP/1.1 302 Found\r\n")?; stream.write_all(b"HTTP/1.1 302 Found\r\n")?;
@@ -120,7 +120,7 @@ fn cookie_and_redirect(mut stream: TcpStream) -> io::Result<()> {
stream.write_all(b"Content-Length: 0\r\n\r\n")?; stream.write_all(b"Content-Length: 0\r\n\r\n")?;
}, },
"/third" => { "/third" => {
if headers.headers().iter().find(|&x| x.contains("Cookie: first")).is_none() { if headers.headers().iter().find(|&x| x.contains("second=true")).is_none() {
panic!("request did not contain cookie 'second'"); panic!("request did not contain cookie 'second'");
} }
stream.write_all(b"HTTP/1.1 200 OK\r\n")?; stream.write_all(b"HTTP/1.1 200 OK\r\n")?;